Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DS to build Ansible Playbooks and Bash scripts #9291

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

jan-cerny
Copy link
Collaborator

@jan-cerny jan-cerny commented Aug 4, 2022

With this change, the SCAP source data stream file will be used to
generate Bash remediation scripts and Ansible Playbooks instead of old
XCCDF 1.1. The generated files will contain long IDs (with the
xccdf_org.ssgproject_content prefix) instead of short IDs, which
shouldn't cause troubles.

@jan-cerny jan-cerny added the Infrastructure Our content build system label Aug 4, 2022
@jan-cerny jan-cerny added this to the 0.1.64 milestone Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

With this change, the SCAP source data stream file will be used to
generate Bash remediation scripts and Ansible Playbooks instead of old
XCCDF 1.1.  The generated files will contain long IDs (with the
xccdf_org.ssgproject_content prefix) instead of short IDs, which
shouldn't cause troubles.
@jan-cerny jan-cerny changed the title Use XCCDF 1.2 to build Ansible Playbooks and Bash scripts Use DS to build Ansible Playbooks and Bash scripts Aug 4, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 4, 2022

Code Climate has analyzed commit f59ae7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato self-assigned this Aug 4, 2022
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I could only notice the long IDs in the header and comments, the Ansible task's tags remain with the short ID.

@yuumasato yuumasato merged commit 7fc571c into ComplianceAsCode:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system XCCDF12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants