Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning to audit_rules_for_ospp #9303

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add warning to audit_rules_for_ospp
  • the warning is the same as for audit_basic_configuration

Rationale:

The reason is that the rule audit_rules_for_ospp technicaly does the same thing as when audit_basic_configuration rule is being used. Audit rules_for_ospp does of course more, but the rule is included in its remediation and check.

…sic_configuration applies

the rule audit_rules_for_ospp actually includes the same file as used within audit_basic_configuration
@vojtapolasek vojtapolasek added Update Rule Issues or pull requests related to Rules updates. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. OSPP OSPP benchmark related. labels Aug 8, 2022
@vojtapolasek vojtapolasek added this to the 0.1.64 milestone Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2022

Code Climate has analyzed commit ac2d71c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@vojtapolasek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high ac2d71c link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-rhcos4-moderate ac2d71c link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuumasato yuumasato self-assigned this Aug 9, 2022
@yuumasato yuumasato merged commit 66e4983 into ComplianceAsCode:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSPP OSPP benchmark related. RHEL7 Red Hat Enterprise Linux 7 product related. RHEL8 Red Hat Enterprise Linux 8 product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants