Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change rules protecting boot in RHEL8 OSPP #9306

Merged
merged 0 commits into from
Aug 10, 2022
Merged

change rules protecting boot in RHEL8 OSPP #9306

merged 0 commits into from
Aug 10, 2022

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • switch grub2_disable_interactive_boot for grub2_disable_recover in RHEL8 OSOSPP
  • add RHEL8 CCE identifier to grub2_disable_recovery
  • modify test data for RHEL8 OSPP

Rationale:

OSPP alignment

@vojtapolasek vojtapolasek added Update Rule Issues or pull requests related to Rules updates. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. OSPP OSPP benchmark related. labels Aug 8, 2022
@vojtapolasek vojtapolasek added this to the 0.1.64 milestone Aug 8, 2022
@vojtapolasek vojtapolasek requested a review from a team as a code owner August 8, 2022 14:59
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 8, 2022

Code Climate has analyzed commit 5a1cb741 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@vojtapolasek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 5a1cb74 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high 5a1cb74 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuumasato yuumasato self-assigned this Aug 10, 2022
@yuumasato
Copy link
Member

yuumasato commented Aug 10, 2022 •
edited

@vojtapolasek Please fix the CCE conflict

@vojtapolasek vojtapolasek merged commit 72fc6ad into ComplianceAsCode:master Aug 10, 2022
@vojtapolasek vojtapolasek force-pushed the fix_rhel8_ospp_interactive_boot branch from 5a1cb74 to 72fc6ad Compare August 10, 2022 06:52
@yuumasato yuumasato removed this from the 0.1.64 milestone Aug 11, 2022
@yuumasato
Copy link
Member

This branch is pointing to an already merged commit, so GH thinks it is already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuumasato yuumasato yuumasato approved these changes

Assignees

@yuumasato yuumasato

Labels
OSPP OSPP benchmark related. RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vojtapolasek @yuumasato