Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sysctl OVAL 5.10 build #9311

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Aug 8, 2022

Description:

  • Fix sysctl OVAL 5.10 build

@ggbecker ggbecker added the bugfix Fixes to reported bugs. label Aug 8, 2022
@ggbecker ggbecker added this to the 0.1.64 milestone Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Aug 8, 2022
@Mab879
Copy link
Member

Mab879 commented Aug 8, 2022

This PR appears to only fix the build for RHEL 8; this helps but doesn't appear to fix the complete OVAL 5.10 build.

@yuumasato yuumasato assigned yuumasato and Mab879 and unassigned Mab879 Aug 9, 2022
@ggbecker
Copy link
Member Author

ggbecker commented Aug 9, 2022

This PR appears to only fix the build for RHEL 8; this helps but doesn't appear to fix the complete OVAL 5.10 build.

All right, I'm going to check on other distributions as well. Thanks for the review.

@ggbecker
Copy link
Member Author

ggbecker commented Aug 9, 2022

I have simplified the PR and compared with previous 5.10 criteria and it should match correctly what is expected to be present in OVAL5.10. The 5.10 sanity build now includes all rhel versions.

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2022

Code Climate has analyzed commit 19d5056 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2022

@ggbecker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 19d5056 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high 19d5056 link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-ocp4-cis-node 19d5056 link true /test e2e-aws-ocp4-cis-node
ci/prow/e2e-aws-ocp4-high-node 19d5056 link true /test e2e-aws-ocp4-high-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Mab879 Mab879 merged commit 26b054e into ComplianceAsCode:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants