Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include warning about the pam_securetty.so PAM module #9348

Merged

Conversation

marcusburghardt
Copy link
Member

Description:

The no_direct_root_logins rule checks and remediate the /etc/securetty file, which is used by the pam_securetty.so module. Currently, this module is no longer enabled by default in many distros. It was included a warning message to make the user aware of this, since the /etc/securetty file is useless without the pam_securetty.so module properly enabled.

Rationale:

Increase awareness for the users

The no_direct_root_logins rule checks and remediate the /etc/securetty file,
which is used by the pam_securetty.so module. Currently, this module is no
longer enabled by default in many distros. It was included a warning
message to make the user aware of this, since the /etc/securetty file is
useless without the pam_securetty.so module properly enabled.
@marcusburghardt marcusburghardt added the Update Rule Issues or pull requests related to Rules updates. label Aug 16, 2022
@marcusburghardt marcusburghardt added this to the 0.1.64 milestone Aug 16, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 16, 2022

Code Climate has analyzed commit 31492f1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

Comment on lines +15 to +17

<ind:textfilecontent54_object id="object_etc_securetty_exists" version="1"
comment="/etc/securetty file exists">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: We usually avoid checking whitespace changes in, because it just adds noise during the review, the reviewer needs to examine what exactly changes there. Don't remove them now but try avoiding it in future PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware @jan-cerny . Since it was a very small change I chose to keep them with the other changes.

@jan-cerny jan-cerny self-assigned this Aug 16, 2022
@jan-cerny jan-cerny merged commit 871f045 into ComplianceAsCode:master Aug 16, 2022
@marcusburghardt marcusburghardt deleted the no_direct_root_logins branch August 16, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants