-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid sed hack #9363
Avoid sed hack #9363
Conversation
Skipping CI for Draft Pull Request. |
Instead of modifying the generated XCCDF file by using sed command, we can directly generate an XCCDF file containing the correct strings from the beginning. To do that, we need to rename the interim internal build artifacts (oval-linked.xml and ocil-linked.xml). However, it will help us streamline our build process in future.
8614d46
to
2c97113
Compare
Code Climate has analyzed commit 2c97113 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.3% (0.0% change). View more on Code Climate. |
I have rebased the PR on the top of the latest upstream master branch. |
The only disadvantage is that the output of the |
Test failures are unrealted to the PR, there are just a couple of STIG rules that can't be hardened. |
Instead of modifying the generated XCCDF file by using sed command, we
can directly generate an XCCDF file containing the correct strings from
the beginning. To do that, we need to rename the interim internal build
artifacts (oval-linked.xml and ocil-linked.xml). However, it will help
us streamline our build process in future.