Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trim_trailing_whitespace to editorconfig #9391

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Aug 23, 2022

Description:

Add trim_trailing_whitespace to .editorconfig.

Rationale:

To better follow the style guide.

To better follow the style guide.
@Mab879 Mab879 added the Infrastructure Our content build system label Aug 23, 2022
@Mab879 Mab879 added this to the 0.1.64 milestone Aug 23, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2022

Code Climate has analyzed commit 294a4ee and detected 45 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 45

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 marked this pull request as ready for review August 23, 2022 18:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 23, 2022
@Mab879
Copy link
Member Author

Mab879 commented Aug 23, 2022

The increase in Codeclimate errors is expected due to adding trailing spaces as a finding.

@jan-cerny jan-cerny self-assigned this Aug 24, 2022
@jan-cerny jan-cerny merged commit 771a398 into ComplianceAsCode:master Aug 24, 2022
@Mab879 Mab879 deleted the editorconfig_trim_trailing_whitespace branch August 24, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants