Fix 2 ctest shellcheck issues #9398
Conversation
Example of the same issue:
In build/jre/fixes/bash/java_jre_unsigned_applications.sh line 8:
mkdir -p -m 755 ${JAVA_DIR}
^-- SC2174: When used with -p, -m only applies to the deepest directory.
For more information:
https://www.shellcheck.net/wiki/SC2174 -- When used with -p, -m only applie...
When using mkdir -p there is no need to check if directory exists.
Other possible solution is to drop -m option.
In build/ol7/fixes/bash/accounts_authorized_local_users_sidadm_orasid.sh line 22:
if [ $(ls -ld "$path" | awk '{print $3}') = "oracle" ]; then
^-- SC2046: Quote this to prevent word splitting.
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
|
Hi @maage. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit b51abcb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.5% (0.0% change). View more on Code Climate. |
|
The failed tests for Automatus CS8, CS9 and Fedora can be safely waived for this PR. |
Description:
Some ctest shellcheck fails.
Rationale:
It is nice that ctests pass.