Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for upstart init system #9452

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Remove checks and remediations that used to support products that usedupstart.

Rationale:

  • No product uses upstart at the moment.
  • Removes unused code from the project.

@yuumasato yuumasato added this to the 0.1.64 milestone Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
bash remediation for rule 'xccdf_org.ssgproject.content_rule_rsyslog_cron_logging' differs:
--- old datastream
+++ new datastream
@@ -6,7 +6,6 @@
 echo "cron.* /var/log/cron" >> /etc/rsyslog.d/cron.conf
 fi
 
-
 systemctl restart rsyslog.service
 
 else

@codeclimate
Copy link

codeclimate bot commented Sep 1, 2022

Code Climate has analyzed commit 399f578 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.3% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member Author

yuumasato commented Sep 1, 2022

The Automatus errors happen because the service enabled/disabled rules are not fit for testing in containers.

@yuumasato
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

@yuumasato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 399f578 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high 399f578 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marcusburghardt marcusburghardt self-assigned this Sep 2, 2022
@marcusburghardt marcusburghardt added the enhancement General enhancements to the project. label Sep 2, 2022
@marcusburghardt
Copy link
Member

I confirmed the failed tests were due to the test environment. Locally, in VMs, the rules passed.

@marcusburghardt marcusburghardt merged commit b55bf7c into ComplianceAsCode:master Sep 6, 2022
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Sep 6, 2022
@yuumasato yuumasato deleted the remove_upstart_support branch September 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants