Make groups inherit platforms from parent groups #9465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules will now inherit platforms from the whole group hierarchy not only the direct parent.
evgenyz
added
Infrastructure
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 00fc551 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 50.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.4% (0.1% change). View more on Code Climate. |
jan-cerny
approved these changes
Sep 2, 2022
|
Good job, the compiled rule now also contains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a creative revert of the revert (#6807) of the fix (#6772).
Description:
Rules will now inherit platforms from the whole group hierarchy not only the direct parent.
Rationale:
Previous implementation propagated group platforms to rules only from the closest group in hierarchy. This fixes it. you can see a good example with rule file_groupowner_efi_grub2_cfg. Before this PR, the rule inherited only platform "uefi". After this PR, it inherits also "grub2". This manifests in the rule remediation. Before this PR the remediation was actually not checking if grub2 package is installed.