install_vm.py: add new option for disk size specification #9479
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit d4bdda6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.4% (0.0% change). View more on Code Climate. |
| "--disk-size", | ||
| dest="disk_size", | ||
| default=20, | ||
| help="Size of the VM qcow2 disk, default is 20 GiB (ignored when --disk is specified)." |
There was a problem hiding this comment.
Instead of ignoring you can try marking them as mutually exclusive group: https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_mutually_exclusive_group
There was a problem hiding this comment.
The --disk-dir and --disk-size options can be used together, but when --disk option is specified it will have higher priority and will overwrite the other two. This is not possible to implement using ArgumentParser.add_mutually_exclusive_group, as it would need to work with subgroup of arguments (because of --disk-dir and --disk-size not being mutually exclusive).
Added a new option
--disk-sizeto specify a size of the installed VM qcow2 disk.