Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to clean_components_post_updating #9530

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Add tests to clean_components_post_updating #9530

merged 2 commits into from
Sep 13, 2022

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Sep 13, 2022

Description:

  • Add tests to clean_components_post_updating

Rationale:

  • This rule didn't have tests

@Xeicker
Add tests to clean_components_post_updating
bc4a6e0 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Sep 13, 2022
@Mab879 Mab879 added Fedora Fedora product related. RHEL Red Hat Enterprise Linux product related. Oracle Linux Oracle Linux product related. Update Rule Issues or pull requests related to Rules updates. labels Sep 13, 2022
@Mab879 Mab879 added this to the 0.1.64 milestone Sep 13, 2022
@Xeicker @Mab879
Apply suggestions from code review
a5d8a70 
Add fedora platform to tests in clean_components_post_updating

Co-authored-by: Matthew Burket <m@tthewburket.com>
@codeclimate
Copy link

codeclimate bot commented Sep 13, 2022

Code Climate has analyzed commit a5d8a70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit c709561 into ComplianceAsCode:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Fedora Fedora product related. needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. RHEL Red Hat Enterprise Linux product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.64
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xeicker @Mab879