Clarify instructions for implementing SCCs #9569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
rhmdnd
force-pushed
the
clarify-ssc-instructions
branch
2 times, most recently
from
94d6c9c
to
a9a82e6
Compare
Mab879
added
OpenShift
jhrozek
approved these changes
Sep 27, 2022
|
@Mab879 Nope, just clarifying some instructions so they're easier to understand. We wanted to have someone from CaC put eyes on it though. |
Mab879
reviewed
Sep 30, 2022
We advise users to deploy security context constraints to secure pods. This is especially important with OpenShift 4, which comes with default security context constraints enabled and ready to use. Previously, the documentation for using security context constraints was vague. This is somewhat understandable since using security context constrains is open-ended, and really depends on application and pods running within a cluster. This commit tries to clarify the instructions by briefly introducing security context constraints, and leaving the educational heavy lifting to another OpenShift document that's dedicated to describing that feature and how to use it effectively. Jira: https://issues.redhat.com/browse/OCPBUGS-698
rhmdnd
force-pushed
the
clarify-ssc-instructions
branch
from
a9a82e6
to
4415efc
Compare
|
Code Climate has analyzed commit 4415efc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We advise users to deploy security context constraints to secure pods. This is especially important with OpenShift 4, which comes with default security context constraints enabled and ready to use.
Previously, the documentation for using security context constraints was vague. This is somewhat understandable since using security context constrains is open-ended, and really depends on application and pods running within a cluster.
This commit tries to clarify the instructions by briefly introducing security context constraints, and leaving the educational heavy lifting to another OpenShift document that's dedicated to describing that feature and how to use it effectively.
Jira: https://issues.redhat.com/browse/OCPBUGS-698