SRG Import/Export Uses Policy Specific Content #9570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
jan-cerny
changed the title
jan-cerny
reviewed
Sep 27, 2022
Comment on lines
+413
to
+419
| psc = rule_object.policy_specific_content | ||
| if not psc: | ||
| return "" | ||
| stig = psc.get('stig') | ||
| if not stig: | ||
| return "" | ||
| return stig.get(key, "") |
There was a problem hiding this comment.
I think that it should pick the content from rule.yml if a policy specific key isn't present.
There was a problem hiding this comment.
With the new import process, my plan was to remove the existing keys once the existing content was migrated to policy files.
|
Code Climate has analyzed commit 0d0d805 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.7% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Convert
utils/import_srg_spreadsheet.pyandutils/create_srg_export.pyto use thepolicy_specific_contentattribute of rules.Rationale:
Use the fields introduced in #9553 to help with SRG import and cleaning up the code.