Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ident_size for .py files from editorconfig #9603

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Sep 30, 2022

Description:

Removes ident_size from .editorconfig for .py files.

Rationale:

This was causing issues with Code Climate.

This was causing issues with Code Climate.
@Mab879 Mab879 added the Infrastructure Our content build system label Sep 30, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Sep 30, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 30, 2022

Code Climate has analyzed commit df41be2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.7% (0.0% change).

View more on Code Climate.

Copy link
Member

@matejak matejak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CodeClimate wasn't able to support continued indentation.

@matejak matejak merged commit ace670c into ComplianceAsCode:master Oct 3, 2022
@Mab879 Mab879 deleted the editor_config_py_fix branch October 3, 2022 15:07
@matejak
Copy link
Member

matejak commented Oct 4, 2022

Interestingly, #9593's CodeClimate inspection still shows invalid indentation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants