Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Improvements #9646

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 6, 2022

Description:

  • Update cmake_minimum_required to 2.8.12 to silence a deprecation warning
  • Add a status for SCE content

Rationale:

  • Clean up output
  • Help inform developers

@Mab879 Mab879 added the Infrastructure Our content build system label Oct 6, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 marked this pull request as draft October 6, 2022 20:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 6, 2022
@Mab879
Copy link
Member Author

Mab879 commented Oct 6, 2022

So it seems that CentOS 7 is still using Cmake 2.8. I will need to rethink this one.

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2022

Code Climate has analyzed commit a8097a1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 marked this pull request as ready for review October 10, 2022 17:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 10, 2022
@Mab879 Mab879 changed the title Cmake improvements CMa improvements Oct 10, 2022
@Mab879 Mab879 changed the title CMa improvements CMake Improvements Oct 10, 2022
@marcusburghardt marcusburghardt self-assigned this Oct 11, 2022
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mab879

@marcusburghardt marcusburghardt merged commit f0e6f82 into ComplianceAsCode:master Oct 12, 2022
@Mab879 Mab879 deleted the cmake_improvements branch October 12, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants