Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include SLE products into the CCE tooling for auto assignment #9714

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Include SLE products into the CCE tooling for auto assignment #9714

merged 5 commits into from
Oct 21, 2022

Conversation

ggbecker
Copy link
Member

Description:

  • Include SLE products into the CCE tooling for auto assignment.
  • CCE files were renamed to match the product name (sles12 -> sle12; sles15 -> sle15).
  • Added new line to the CCE files which were missing.
  • Added documentation for the add-cce subcommand of fix_rules.py utility.
  • Remove broken link about CCE syntax.

Rationale:

  • CCE files from other distros are integrated into our automated tooling for CCE assignment.

@rumch-se FYI

@ggbecker ggbecker added Documentation Update in project documentation. SLES SUSE Linux Enterprise Server product related. labels Oct 20, 2022
@ggbecker ggbecker added this to the 0.1.65 milestone Oct 20, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny jan-cerny changed the title Include SLE products into the CCE tooling for auto assignment. Include SLE products into the CCE tooling for auto assignment Oct 21, 2022
jan-cerny
jan-cerny approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing

docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
@jan-cerny jan-cerny self-assigned this Oct 21, 2022
@ggbecker @jan-cerny
Update docs/manual/developer/05_tools_and_utilities.md
8e1fd42 
Co-authored-by: Jan Černý <jcerny@redhat.com>
@ggbecker
Copy link
Member Author

@anivan-suse FYI

@anivan-suse
Copy link
Contributor

@anivan-suse FYI

Thanks for the update! @teacup-on-rockingchair FYI as well :)

@codeclimate
Copy link

codeclimate bot commented Oct 21, 2022

Code Climate has analyzed commit 8e1fd42 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 80.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.6% (5.6% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit dead445 into ComplianceAsCode:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
Documentation Update in project documentation. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Milestone
0.1.65
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggbecker @anivan-suse @jan-cerny