Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rules to PCI DSS 4.0 SLES 15 profile #9716

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

rumch-se
Copy link
Contributor

Description:

  • Added rules to SLES 15 PCI DSS 4.0 profile

Rationale:

  • The profile includes rules which support new recommendations of PCI DSS - 4.0

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Oct 20, 2022
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Mab879 Mab879 self-assigned this Oct 20, 2022
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. pci-dss Update Profile Issues or pull requests related to Profiles updates. labels Oct 20, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Oct 20, 2022
@Mab879
Copy link
Member

Mab879 commented Oct 20, 2022

@rumch-se Please rebase this PR.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Oct 21, 2022
@rumch-se
Copy link
Contributor Author

Hi @Mab879
I have done the requested rebase
Have a nice day
Rumen

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks like the rule sshd_set_max_sessions needs a CCE assigned. Once the rule has a CCE assigned that should fix the tests.

@rumch-se
Copy link
Contributor Author

Hello @Mab879
I have done the proposed change
Have a nice day
Rumen

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2022

Code Climate has analyzed commit 3f84a41 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.5% (0.3% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; waving the Fedora Rawhide test as there is a bug in Fedora Rawhide currently.

@Mab879 Mab879 merged commit f68ca3d into ComplianceAsCode:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. pci-dss SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants