Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu specific bash for ensure_rsyslog_log_file_configuration #9719

Merged

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Oct 20, 2022

Description:

  • Add Ubuntu specific bash for ensure_rsyslog_log_file_configuration
  • Also fixed the regex of the shared bash and OVAL to avoid matching commented lines.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

Hi @dodys. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
bash remediation for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring' differs.
--- xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring
+++ xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring
@@ -1,7 +1,7 @@
 # Remediation is applicable only in certain platforms
 if [ ! -f /.dockerenv ] && [ ! -f /run/.containerenv ]; then
 
-declare -A REMOTE_METHODS=( ['auth.*']='^.*auth\.\*.*$' ['authpriv.*']='^.*authpriv\.\*.*$' ['daemon.*']='^.*daemon\.\*.*$' )
+declare -A REMOTE_METHODS=( ['auth.*']='^[^#]*auth\.\*.*$' ['authpriv.*']='^[^#]*authpriv\.\*.*$' ['daemon.*']='^[^#]*daemon\.\*.*$' )
 
 if [[ ! -f /etc/rsyslog.conf ]]; then
 # Something is not right, create the file

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2022

Code Climate has analyzed commit bf2078d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 41.6% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.65 milestone Oct 20, 2022
@Mab879 Mab879 added OVAL OVAL update. Related to the systems assessments. Bash Bash remediation update. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates. labels Oct 20, 2022
@jan-cerny jan-cerny self-assigned this Oct 21, 2022
@jan-cerny jan-cerny merged commit 913b9c6 into ComplianceAsCode:master Oct 21, 2022
@dodys dodys deleted the ensure_rsyslog_log_file_configuration branch April 17, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants