Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLE 15 SAP hardening profile #9742

Merged

Conversation

brett060102
Copy link
Contributor

Update the profile title and description to more closely match published documents on product.

Add package install rules. Testing with minimal installs showed that some of the assumptions we made about what was installed by default was incorrect.

Description:

Rationale:

  • reduce user confusion
  • enable use of the profile with remediation outside of the image build process

Update the profile title and description to more closely match published
documents on product.

Add package install rules. Testing with minimal installs showed that some of
the assumptions we made about what was installed by default was incorrect.
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

Hi @brett060102. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 27, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2022

Code Climate has analyzed commit a519fb6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Oct 28, 2022
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. labels Oct 28, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Oct 28, 2022
@Mab879 Mab879 merged commit 0822a60 into ComplianceAsCode:master Oct 28, 2022
@brett060102 brett060102 deleted the pcs-hardening-sap-updates branch June 28, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants