Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rule deprecation instructions and agreements #9797

Merged
merged 5 commits into from
Nov 17, 2022

Conversation

marcusburghardt
Copy link
Member

Description:

There are few cases where rules were depracted in favor of newer rules. A discussion was conducted among the maintainers and some agreements were make. The agreements and the procedures to satisfy these agreements are not documented.

Rationale:

Transparency and quality standards

Review Hints:

There are more detailed context for this topic in the following PRs:

@marcusburghardt marcusburghardt added the Documentation Update in project documentation. label Nov 9, 2022
@marcusburghardt marcusburghardt added this to the 0.1.65 milestone Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

There are few cases where rules were deprecated in favor of newer rules.
A discussion was conducted among the maintainers and some agreements
were make. The agreements and the procedures to satisfy these agreements
are not documented.
Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great idea

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left a few suggestions.

If you don't take my suggestions, please make sure that you replace the "smart quotes" in PR as they go against the project style guide.

docs/manual/developer/06_contributing_with_content.md Outdated Show resolved Hide resolved
docs/manual/developer/06_contributing_with_content.md Outdated Show resolved Hide resolved
docs/manual/developer/06_contributing_with_content.md Outdated Show resolved Hide resolved
marcusburghardt and others added 2 commits November 9, 2022 15:05
Co-authored-by: Matthew Burket <m@tthewburket.com>
Co-authored-by: Matthew Burket <m@tthewburket.com>
@marcusburghardt
Copy link
Member Author

/retest

@Mab879
Copy link
Member

Mab879 commented Nov 9, 2022

You will need to push again @marcusburghardt. GitHub had an outage that prevented the actions from being triggered.

Co-authored-by: Matthew Burket <m@tthewburket.com>
@marcusburghardt
Copy link
Member Author

You will need to push again @marcusburghardt. GitHub had an outage that prevented the actions from being triggered.

Done.

@codeclimate
Copy link

codeclimate bot commented Nov 9, 2022

Code Climate has analyzed commit 8be3136 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.8% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, looks good to me.

@Mab879
Copy link
Member

Mab879 commented Nov 11, 2022

/packit build

@Mab879
Copy link
Member

Mab879 commented Nov 17, 2022

Seeing no objections, merging.

@Mab879 Mab879 merged commit dc8e81f into ComplianceAsCode:master Nov 17, 2022
@marcusburghardt marcusburghardt deleted the doc_rules_names branch November 18, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants