-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document rule deprecation instructions and agreements #9797
Document rule deprecation instructions and agreements #9797
Conversation
There are few cases where rules were deprecated in favor of newer rules. A discussion was conducted among the maintainers and some agreements were make. The agreements and the procedures to satisfy these agreements are not documented.
056a5a7
to
f996d87
Compare
Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left a few suggestions.
If you don't take my suggestions, please make sure that you replace the "smart quotes" in PR as they go against the project style guide.
Co-authored-by: Matthew Burket <m@tthewburket.com>
Co-authored-by: Matthew Burket <m@tthewburket.com>
/retest |
You will need to push again @marcusburghardt. GitHub had an outage that prevented the actions from being triggered. |
Co-authored-by: Matthew Burket <m@tthewburket.com>
daa32fc
to
8be3136
Compare
Done. |
Code Climate has analyzed commit 8be3136 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.8% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, looks good to me.
/packit build |
Seeing no objections, merging. |
Description:
There are few cases where rules were depracted in favor of newer rules. A discussion was conducted among the maintainers and some agreements were make. The agreements and the procedures to satisfy these agreements are not documented.
Rationale:
Transparency and quality standards
Review Hints:
There are more detailed context for this topic in the following PRs: