Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshd_lineinfile: Add tests for duplicated params #9802

Conversation

yuumasato
Copy link
Member

Description:

  • Add tests to ensure that the template evaluates to pass multiple configurations of the parameter with the compliant value.
    • These tests are complementary to param_conflict.fail.sh and param_conflict_directory.fail.sh

Rationale:

  • This helps ensure that the template/macro behavior is as expected.

Add tests to ensure that the template evaluates to pass multiple
configurations of the parameter with the compliant value.
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Nov 10, 2022

Code Climate has analyzed commit 6876bf1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.8%.

View more on Code Climate.

@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Nov 10, 2022
@marcusburghardt marcusburghardt added this to the 0.1.65 milestone Nov 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

@yuumasato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 6876bf1 link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-ocp4-stig 6876bf1 link true /test e2e-aws-ocp4-stig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Mab879 Mab879 self-assigned this Nov 11, 2022
@Mab879
Copy link
Member

Mab879 commented Nov 11, 2022

/packit build

@Mab879 Mab879 merged commit ce55e49 into ComplianceAsCode:master Nov 11, 2022
@yuumasato yuumasato deleted the test-sshd_lineinfile-allows-duplicates branch November 14, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants