Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts_passwords: Add tests for value conflicts and duplicates #9804

Conversation

yuumasato
Copy link
Member

Description:

  • Add tests to ensure that the rule can check and remediate parameter configuration that are in conflict with each other or duplicate each other.

Rationale:

  • A rule behavior that is not tested is not ensured and maintained.

Rename test so that it aligns with the common pattern and opens up room
for a similar test scenario without directories.
@yuumasato yuumasato added RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Nov 10, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Add tests for conflicting and duplicate values
@yuumasato yuumasato force-pushed the accounts_passwords_conflicts_and_duplicates branch from 4b234bc to 7e2c7cc Compare November 10, 2022 13:10
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

@yuumasato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-pci-dss-node 7e2c7cc link true /test e2e-aws-ocp4-pci-dss-node
ci/prow/e2e-aws-ocp4-moderate 7e2c7cc link true /test e2e-aws-ocp4-moderate
ci/prow/e2e-aws-ocp4-cis 7e2c7cc link true /test e2e-aws-ocp4-cis

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codeclimate
Copy link

codeclimate bot commented Nov 10, 2022

Code Climate has analyzed commit 7e2c7cc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.8% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Nov 11, 2022

/packit build

@Mab879 Mab879 self-assigned this Nov 11, 2022
@Mab879 Mab879 added this to the 0.1.65 milestone Nov 11, 2022
@Mab879 Mab879 added the Test Suite Update in Test Suite. label Nov 11, 2022
@Mab879 Mab879 merged commit 17b8b57 into ComplianceAsCode:master Nov 11, 2022
@yuumasato yuumasato deleted the accounts_passwords_conflicts_and_duplicates branch November 14, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants