Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sanity test for utils/create_scap_delta_tailoring.py #9839

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 16, 2022

Description:

  • Adds a quick sanity test for utils/create_scap_delta_tailoring.py

Rationale:

Help catch errors early.

@Mab879 Mab879 added the Infrastructure Our content build system label Nov 16, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.65 milestone Nov 16, 2022
@Mab879 Mab879 marked this pull request as draft November 16, 2022 23:33
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 16, 2022
@Mab879 Mab879 force-pushed the sanity_check_stig_delta_tailoring branch from e206bc0 to 7d9fb85 Compare November 17, 2022 16:39
@Mab879 Mab879 marked this pull request as ready for review November 17, 2022 16:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 17, 2022
@Mab879
Copy link
Member Author

Mab879 commented Nov 17, 2022

/packit test

1 similar comment
@Mab879
Copy link
Member Author

Mab879 commented Nov 18, 2022

/packit test

@jan-cerny jan-cerny self-assigned this Nov 21, 2022
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an idea that you could add some dry run mode as you have done in the previous PR and that would prevent the long output that contains many messages "Set rule ... selection state to false" in the output.

@Mab879 Mab879 force-pushed the sanity_check_stig_delta_tailoring branch 2 times, most recently from 3815e44 to cf751e5 Compare November 21, 2022 22:05
@marcusburghardt marcusburghardt modified the milestones: 0.1.65, 0.1.66 Nov 22, 2022
@Mab879 Mab879 force-pushed the sanity_check_stig_delta_tailoring branch from cf751e5 to 6a55054 Compare November 22, 2022 17:57
tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Nov 30, 2022

Code Climate has analyzed commit d672fcf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.6% (1.5% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the tests locally and I also have seen that they run in our CI.

@jan-cerny jan-cerny merged commit a0f6a91 into ComplianceAsCode:master Dec 1, 2022
@Mab879 Mab879 deleted the sanity_check_stig_delta_tailoring branch December 1, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants