Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sanity Test for generate_contributors.py #9845

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Nov 18, 2022

Description:

  • Add dry run option to generate_contributors.py
  • Add sanity test for generate_contributors.py

Rationale:

Find issues sooner.

@Mab879 Mab879 added the Documentation Update in project documentation. label Nov 18, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Nov 18, 2022

Code Climate has analyzed commit 6aa0fbb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.1% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Nov 21, 2022
@jan-cerny jan-cerny added this to the 0.1.65 milestone Nov 21, 2022
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen the test-generate_contributors passing in the CI run on Fedora latest and I have also executed the test locally and when I break the generate function it started to fail as expected.

@jan-cerny jan-cerny merged commit 9c9f7c2 into ComplianceAsCode:master Nov 21, 2022
@Mab879 Mab879 deleted the add_contribs_sanity branch November 21, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants