Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUSE Manager 4.x in installed_OS_is_sle15 #9854

Conversation

DriverXavGeForce
Copy link
Contributor

Description:

  • Add SUSE Manager 4.x as a product based on SLES 15.

Rationale:

  • Add SUSE Manager 4.x in installed_OS_is_sle15

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2022

Hi @DriverXavGeForce. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit 062b3a2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.1% (0.0% change).

View more on Code Climate.

@ggbecker ggbecker requested a review from a team November 23, 2022 13:25
@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. OVAL OVAL update. Related to the systems assessments. labels Nov 30, 2022
@marcusburghardt
Copy link
Member

marcusburghardt commented Nov 30, 2022

Thanks for the contribution @DriverXavGeForce.
The patch seems good. I would just wait a confirmation from a SUSE maintainer. @ComplianceAsCode/suse-maintainers

@anivan-suse
Copy link
Contributor

Looks good to me as well, approved.

@anivan-suse anivan-suse merged commit 263c9b2 into ComplianceAsCode:master Dec 1, 2022
@Mab879 Mab879 added this to the 0.1.66 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants