Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new SLE 12/15's rule package_rcpbind_removed #9931

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Dec 6, 2022

Description:

  • A new rule in addition to the existing rule service_rpcbind_disabled

Rationale:

  • This new rule covers CIS's requirement 2.2.8 Ensure rpcbind is not installed or the rpcbind services are masked
    (Automated)

Review Hints:

  • Review hints here. Replace this text. Don't use the italics format!

  • Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.

  • Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.

@rumch-se rumch-se requested a review from a team as a code owner December 6, 2022 11:26
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.66 milestone Dec 6, 2022
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. New Rule Issues or pull requests related to new Rules. CIS CIS Benchmark related. labels Dec 6, 2022
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@anivan-suse anivan-suse added the needs-rebase Used by openshift-ci bot. label Dec 13, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Dec 14, 2022
@anivan-suse anivan-suse added the needs-rebase Used by openshift-ci bot. label Dec 21, 2022
@Mab879
Copy link
Member

Mab879 commented Jan 6, 2023

@rumch-se Can you please rebase this PR?

@openshift-merge-robot openshift-merge-robot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Jan 9, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jan 11, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 11, 2023

Code Climate has analyzed commit 6515e34 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 0c6c123 into ComplianceAsCode:master Jan 11, 2023
@marcusburghardt
Copy link
Member

@rumch-se and @teacup-on-rockingchair , thanks to @dodys , a thread was started on Gitter about the package name.
For RHEL and Ubuntu systems, the package is called rpcbind. We believe SUSE too.

Could you confirm if the correct package name in SUSE is indeed rcpbind, please? Or should it be rpcbind?

@rumch-se
Copy link
Contributor Author

Hello @marcusburghardt
The correct name of the package for SUSE is rpcbind.
In CIS there is a rule for example
"2.2.8 Ensure rpcbind is not installed or the rpcbind services are masked (Automated)"
Have a nice day
Rumen

@marcusburghardt
Copy link
Member

Ok, so we should rename the rule and its respective content. Thanks @rumch-se .

@rumch-se
Copy link
Contributor Author

Hello @marcusburghardt
I have created a new PR #10054 which corrects this typo error.

Have a nice day
Rumen

@marcusburghardt
Copy link
Member

Hello @marcusburghardt I have created a new PR #10054 which corrects this typo error.

Have a nice day Rumen

Awesome. Thanks Rumen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants