Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash and ansible remediation for set_loopback_traffic #9939

Conversation

hagenest
Copy link
Contributor

@hagenest hagenest commented Dec 7, 2022

  • Description:

Adds ansible and bash remediations for the rule "set_loopback_traffic"

  • Rationale:

Bash remediation was wrong, ansible remediation missing

@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2022

Hi @hagenest. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@anivan-suse anivan-suse added Ansible Ansible remediation update. Bash Bash remediation update. pci-dss labels Dec 7, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 7, 2022

Code Climate has analyzed commit 5e98367 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.8% (0.0% change).

View more on Code Climate.

@anivan-suse anivan-suse merged commit c5ff7a2 into ComplianceAsCode:master Dec 7, 2022
@Mab879 Mab879 added this to the 0.1.66 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. pci-dss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants