Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small corrections related to 3 rules #9995

Merged

Conversation

rumch-se
Copy link
Contributor

Description:

  • Small corrections related to the rules no_direct_root_logins, securetty_root_login_console_only and use_pam_wheel_for_su

Rationale:

  • CIS numbers related to SLE 12/15 were added, " or spaces character ware removed

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2022

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 20, 2022
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rumch-se
Copy link
Contributor Author

Hello @marcusburghardt,

May you help me here, because I don't understand the root cause for errors here? I have removed for some CIS codes related to the RHEL the symbol " before and after these codes. In general 1/we don't use these symbols when we specify the codes in other words we use cis@sle15: 2.3 instead of cis@sle15: "2.3". 2/I passed through a lot of rules, during the development, and only in these rules I found the usage of these symbols.

Have a nice day
Rumen

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3 is getting converted to float in the YAML loading process, which causes problems in the build system. A quick search of the project indicates any time we section a number that looks like a float we quote it.

cis@alinux2: "5.6"
cis@alinux3: "5.8"
cis@rhel7: "5.7"
cis@alinux2: 5.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section numbers like 5.6 need to be quoted. here

@@ -26,7 +26,9 @@ identifiers:

references:
cis-csc: 12,13,14,15,16,18,3,5
cis@alinux3: "5.7"
cis@alinux3: 5.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same story here, quote the section numbers that look floats, (e.g. 5.5).

@Mab879 Mab879 self-assigned this Jan 6, 2023
@rumch-se
Copy link
Contributor Author

rumch-se commented Jan 9, 2023

Hello @Mab879
Thank you for your feedback. I have corrected problematic codes.
Have a nice day
Rumen

@codeclimate
Copy link

codeclimate bot commented Jan 9, 2023

Code Climate has analyzed commit 743e2cc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.9% (0.1% change).

View more on Code Climate.

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. CIS CIS Benchmark related. labels Jan 9, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 9, 2023
@Mab879 Mab879 merged commit 2a362c0 into ComplianceAsCode:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants