-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small corrections related to 3 rules #9995
Small corrections related to 3 rules #9995
Conversation
Hi @rumch-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello @marcusburghardt, May you help me here, because I don't understand the root cause for errors here? I have removed for some CIS codes related to the RHEL the symbol " before and after these codes. In general 1/we don't use these symbols when we specify the codes in other words we use cis@sle15: 2.3 instead of cis@sle15: "2.3". 2/I passed through a lot of rules, during the development, and only in these rules I found the usage of these symbols. Have a nice day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.3
is getting converted to float in the YAML loading process, which causes problems in the build system. A quick search of the project indicates any time we section a number that looks like a float we quote it.
linux_os/guide/system/accounts/accounts-restrictions/root_logins/no_direct_root_logins/rule.yml
Show resolved
Hide resolved
cis@alinux2: "5.6" | ||
cis@alinux3: "5.8" | ||
cis@rhel7: "5.7" | ||
cis@alinux2: 5.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section numbers like 5.6
need to be quoted. here
@@ -26,7 +26,9 @@ identifiers: | |||
|
|||
references: | |||
cis-csc: 12,13,14,15,16,18,3,5 | |||
cis@alinux3: "5.7" | |||
cis@alinux3: 5.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same story here, quote the section numbers that look floats, (e.g. 5.5
).
Hello @Mab879 |
Code Climate has analyzed commit 743e2cc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.9% (0.1% change). View more on Code Climate. |
Description:
Rationale: