handle in uniform manner subtasks

CompliancePal · Mar 23, 2021 · bcb964c · bcb964c
1 parent df49aca
commit bcb964c
Show file tree

Hide file tree

Showing 8 changed files with 264 additions and 231 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/features/Issue.instance.feature → features/Issue.feature b/features/Issue.instance.feature → features/Issue.feature
@@ -47,6 +47,7 @@ Feature: Issue instance
 
         @issue-7
         @issue-15
+        @issue-27
         Scenario: Changes preserves content outside placeholder
             Given event body
                   """
@@ -72,7 +73,7 @@ Feature: Issue instance
                   {
                     "id": "3",
                     "title": "Added",
-                    "closed": false,
+                    "state": "open",
                     "removed": false,
                     "repo": "issue-tracer",
                     "owner": "CompliancePal"
@@ -101,6 +102,7 @@ Feature: Issue instance
                   """
 
         @issue-23
+        @issue-27
         Scenario: Added duplicate cross reference subtask
             Given event body
                   """
@@ -110,14 +112,14 @@ Feature: Issue instance
                   ### Related issues
 
                   - [x] Closed title (CompliancePal/cross-ref#1)
+                  - [ ] Open title (#2)
                   """
-                  # - [ ] Open title (#2)
               And existing cross reference subtask
                   """
                   {
                     "id": "1",
                     "title": "Closed title",
-                    "closed": true,
+                    "state": "closed",
                     "removed": false,
                     "repo": "cross-ref",
                     "owner": "CompliancePal"
@@ -132,10 +134,11 @@ Feature: Issue instance
                   ### Related issues
 
                   - [x] Closed title (CompliancePal/cross-ref#1)
+                  - [ ] Open title (#2)
                   """
-                  # - [ ] Open title (#2)
 
         @issue-11
+        @issue-27
         Scenario: Changes added when the placeholder is at the end of document
             Given body
                   """
@@ -150,7 +153,7 @@ Feature: Issue instance
                   {
                     "id": "3",
                     "title": "Added",
-                    "closed": false,
+                    "state": "open",
                     "removed": false,
                     "repo": "issue-tracer",
                     "owner": "CompliancePal"
@@ -172,6 +175,7 @@ Feature: Issue instance
                   """
 
         @issue-9
+        @issue-27
         Scenario: Changes not added on issue without placeholder
             Given Issue body without placeholder
                   """
@@ -182,7 +186,7 @@ Feature: Issue instance
                   {
                     "id": "3",
                     "title": "Added",
-                    "closed": false,
+                    "state": "open",
                     "removed": false,
                     "repo": "issue-tracer",
                     "owner": "CompliancePal"

diff --git a/src/actions/issues.ts b/src/actions/issues.ts
@@ -2,7 +2,6 @@ import * as core from '@actions/core'
 import * as github from '@actions/github'
 import {IssuesOpenedEvent} from '@octokit/webhooks-definitions/schema'
 import {Issue} from '../domain/Issue'
-import {Subtask} from '../domain/Subtask'
 import {IssuesRepo} from '../repo/Issues'
 
 export const issuesHandler = async (ghToken: string): Promise<void> => {
@@ -37,19 +36,10 @@ export const issuesHandler = async (ghToken: string): Promise<void> => {
         `Related issue ${relatedIssue.number} has ${relatedIssue.subtasks.size} subtasks`
       )
 
-      relatedIssue.addSubtask(
-        Subtask.create({
-          id: issue.number.toString(),
-          title: issue.title,
-          closed: issue.closed,
-          owner: issue.owner,
-          repo: issue.repo,
-          crossReference: relatedIssue.isCrossReference(issue)
-        })
-      )
+      relatedIssue.addSubtask(issue)
 
       await relatedIssue.save(repo)
-      // await repo.save(relatedIssue)
+
       core.info(`Related issue ${relatedIssue.number} updated sucessfuly`)
 
       core.setOutput('partOf', issue.partOf)