Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/mlflow.yml

This file was deleted.

8 changes: 3 additions & 5 deletions .github/workflows/modelcard.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
name: modelcard-test

on:
push:
branches:
- demos/*
pull_request:
branches:
- main
- master
workflow_dispatch:

jobs:
Expand All @@ -19,6 +16,7 @@ jobs:
- name: Check for model card file
uses: CompliancePal/modelcard-action@main
env:
MLFLOW_TRACKING_URI: ${{ secrets.MLFLOW_TRACKING_URI }}
MLFLOW_TRACKING_URI: ${{secrets.MLFLOW_TRACKING_URI}}
with:
modelcard: modelcard.yaml
rules: .rules
12 changes: 12 additions & 0 deletions .rules/functions/semver.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
export default (input) => {
const versionParts = input.split('.');

if (versionParts.length != 3 || versionParts.some((part) => isNaN(part))) {
return [
{
message:
'Version name must be in format MAJOR.MINOR.PATCH, see semantic versioning (https://semver.org/)',
},
];
}
};
8 changes: 8 additions & 0 deletions .rules/rules.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
functions: [semver]
rules:
legal-version-name:
message: '{{error}}'
severity: error
given: '$.model_details.version.name'
then:
function: semver
11 changes: 10 additions & 1 deletion modelcard.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
model_details:
name: Wine prediction
version:
name: 1.0.0
name: 0.0.1
date: 2022-11-03
run:
type: mlflow
id: 35c174ef99c04747b0467aaeabf70773
description: |
<!-- markdown description of model -->
## Wine quality prediction
This model predicts the quality of wine batches based on physicochemical inputs and sensory outputs.
references:
- reference: http://made-up-exam.ple/