Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Issue 33: Refactor validation tool #44

Merged
merged 24 commits into from
Apr 20, 2021
Merged

Issue 33: Refactor validation tool #44

merged 24 commits into from
Apr 20, 2021

Conversation

rssen
Copy link
Contributor

@rssen rssen commented Mar 4, 2021

Description

Refactor the validation tool to simplify its structure.

Closes #33

@rssen rssen requested review from senier and treiher March 4, 2021 11:03
@rssen
Copy link
Contributor Author

rssen commented Mar 4, 2021

In reference to #39 (comment): I first removed this and added it back in later (sort of), for a comparison please see d9d930f. I decided to do this to remove redundant code.

Copy link
Member

@treiher treiher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is limited to general design issues.

tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tests/test_validation_tool.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
@rssen rssen requested a review from treiher March 5, 2021 10:37
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
@rssen
Copy link
Contributor Author

rssen commented Mar 9, 2021

Rebased onto current main

tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tests/test_validation_tool.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tests/test_validation_tool.py Outdated Show resolved Hide resolved
tools/validate_spec.py Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
tools/validate_spec.py Outdated Show resolved Hide resolved
@rssen rssen requested a review from treiher April 8, 2021 09:06
tools/validate_spec.py Outdated Show resolved Hide resolved
@rssen rssen requested a review from treiher April 15, 2021 09:03
@treiher treiher removed the request for review from senier April 20, 2021 08:46
@rssen rssen merged commit 534b3ee into main Apr 20, 2021
@rssen rssen deleted the issue_33 branch April 20, 2021 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor validation tool
2 participants