Review from composable team #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkast
requested changes
Jun 1, 2023
x/transfermiddleware/relay_test.go
Outdated
| // then | ||
| suite.Require().Equal(1, len(suite.chainB.PendingSendPackets)) | ||
|
|
||
| suite.Require().NoError(err) |
There was a problem hiding this comment.
It seems there is this check 2 lines above
There was a problem hiding this comment.
lets keep suite.Require().Equal(1, len(suite.chainB.PendingSendPackets)) check
x/transfermiddleware/relay_test.go
Outdated
| expBalance = sdk.NewCoins(sdk.NewCoin(expDenom, chainBSupply.Amount.Sub(transferAmountFromChainBToChainA))) | ||
| suite.Require().Equal(expBalance, balance) | ||
|
|
||
| // receiver in chain A receive exactly native token that transferd from chain B |
There was a problem hiding this comment.
transferd is a misspelling of transferred (misspell)
x/transfermiddleware/relay_test.go
Outdated
| expBalance = sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, transferAmountFromChainBToChainA)) | ||
| suite.Require().Equal(expBalance, balance) | ||
|
|
||
| // Continue send coin from (chainA) to escrow address in chain B |
There was a problem hiding this comment.
this isnt sent to escrow address but to chainB.senderAccount
|
@kkast thanks for your reviews ! I've push your suggest chain in new commit. |
kkast
approved these changes
Jun 5, 2023
tungle-notional
pushed a commit
to notional-labs/composable-cosmos
that referenced
this pull request
Mar 7, 2024
* TestMintAndEscrowProcess: check more IBC transfer from chain A->B * minor * review from kkast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.