Introduced the validation to not allow ibc with timeout timestamp less then X nanos. #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarkushin
approved these changes
Mar 19, 2024
|
what happen if we auto set --packet-timeout-timestamp to correct value, if validator set incorrect? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
centaurid tx ibc-transfer transfer transfer channel-6 0xF66605eDE7BfCCc460097CAFD34B4924f1C6969D 1000000000000000ppica --from jn --fees 1000000000000ppica --home ~/.centauri-mainnet --keyring-backend "test" --node https://rpc-testnet5.composable-cosmos.composablenodes.tech:443 --chain-id=banksy-testnet-5 --gas=auto --packet-timeout-height 0-5493803 --packet-timeout-timestamp 1710526985000000000
here is an example of IBC transfer from cosmos to eth.
the idea to just reject any transfer where timeout-timestamp is less then specified in configuration for that specific channel.