Onrecvpacket implementation based on Vuong's idea #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expertdicer
changed the title
…s/composable-testnet into nguyen/onrecvpacket
…s/composable-testnet into nguyen/onrecvpacket
GNaD13
reviewed
May 9, 2023
|
One more thing, we need to re-define the transfer keeper here. We need to replace the wraper from channel-keeper to transferMiddleware |
* update genesis and msg server * add secondary index, check IBCdenom in recv packet
vuong177
added a commit
that referenced
this pull request
May 9, 2023
* proto * change name to banksyd * describe for proto * describe for proto * add middleware module * temp ibc func * update genesis and msg server * Onrecvpacket implementation based on Vuong's idea (#88) * init setup test * Add workflow * Add more test and fix bug relevant go.mod * update makefile * ChainCongfig.Images must be >1 * uidgid * ignore go.work and go.work.sum * add push wasm test * add push wasm test workflow * use notional-labs/interchaintest to custom command push wasm * use feat/hyperspace * use new version * request body too large * use v7.0.4 * update push_wasm test * update ibc test * latest * use v7.0.5 * use v7.0.5 * use 7.0.6 * update UidGid to pass permission * increase timeout * v7.0.7 * onrecvpacket implementation * use v7.0.8 * use v7.0.8 * correct logic * go mod tidy * Mint native coin and escrow ibc token * move onrecvpacket code to relay file * add test and mock for test * go mod tidy * test helper * test-helper * bump test_helpers * use 7.1.0 * wait some block * change uidgid 1025:1025 * not mintfund * revert uidgid * add protogen * query proto * query proto * grpc query * grpc query * cli * ibctesting * relay test * module * module * go.mod * update testcase: working middleware flow * remove redundant mock for test * go mod tidy * redundant fmt import * remove redundant println * refactor relay test * use 7.1.1 * ibcmiddleware stack * Onrecvpacket refactor * use v7.1.2 * OnTimeoutPacket implementation * Onrecvpacket implementation fix * fix relay_test.go * using custom simapp * OnTimeoutPacket implementation * go mod tidy and resolve conflict * Review on recv packet (#107) * update genesis and msg server * add secondary index, check IBCdenom in recv packet --------- Co-authored-by: ducnt87 <ntd1312000@gmail.com> Co-authored-by: phamminh0811 <1phamminh0811@gmail.com> Co-authored-by: vuong <56973102+vuong177@users.noreply.github.com> * refactor app.go * proto fix: move to use cosmos/gogoproto * fix: conflic in go dependency --------- Co-authored-by: Lặc <67097720+expertdicer@users.noreply.github.com> Co-authored-by: ducnt87 <ntd1312000@gmail.com> Co-authored-by: phamminh0811 <1phamminh0811@gmail.com>
tungle-notional
pushed a commit
to notional-labs/composable-cosmos
that referenced
this pull request
Mar 7, 2024
* init setup test * Add workflow * Add more test and fix bug relevant go.mod * update makefile * ChainCongfig.Images must be >1 * uidgid * ignore go.work and go.work.sum * add push wasm test * add push wasm test workflow * use notional-labs/interchaintest to custom command push wasm * use feat/hyperspace * use new version * request body too large * use v7.0.4 * update push_wasm test * update ibc test * latest * use v7.0.5 * use v7.0.5 * use 7.0.6 * update UidGid to pass permission * increase timeout * v7.0.7 * onrecvpacket implementation * use v7.0.8 * use v7.0.8 * correct logic * go mod tidy * Mint native coin and escrow ibc token * move onrecvpacket code to relay file * add test and mock for test * go mod tidy * test helper * test-helper * bump test_helpers * use 7.1.0 * wait some block * change uidgid 1025:1025 * not mintfund * revert uidgid * add protogen * query proto * query proto * grpc query * grpc query * cli * ibctesting * relay test * module * module * go.mod * update testcase: working middleware flow * remove redundant mock for test * go mod tidy * redundant fmt import * remove redundant println * refactor relay test * use 7.1.1 * ibcmiddleware stack * Onrecvpacket refactor * use v7.1.2 * OnTimeoutPacket implementation * Onrecvpacket implementation fix * fix relay_test.go * using custom simapp * OnTimeoutPacket implementation * go mod tidy and resolve conflict * Review on recv packet (ComposableFi#107) * update genesis and msg server * add secondary index, check IBCdenom in recv packet --------- Co-authored-by: ducnt87 <ntd1312000@gmail.com> Co-authored-by: phamminh0811 <1phamminh0811@gmail.com> Co-authored-by: vuong <56973102+vuong177@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #29
The current flow of OnrecvPacket of IBC implementation is consists of 2 main action based on a check
if receiver chain is source:receiver.The new implementation of transfer middleware will have 1 more action happens after the check `if receiver chain is source
. OnrecvPacket will now checkif the srcChannel is paraChannel``:receiver.receiver).This implementation is based on this doc