fix: typescript config

ComposableWeb · Jan 27, 2020 · aebe05f · aebe05f
1 parent 9b005d7
commit aebe05f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/browser-extension/package.json b/packages/browser-extension/package.json
@@ -5,6 +5,7 @@
   "main": "index.js",
   "scripts": {
     "watch": "webpack --config webpack/webpack.dev.js --watch",
+    "prebuild": "yarn clean",
     "build": "webpack --config webpack/webpack.prod.js",
     "clean": "rimraf dist"
   },

diff --git a/packages/browser-extension/src/background.ts b/packages/browser-extension/src/background.ts
@@ -1,4 +1,4 @@
-async function savePage<T>(url: string, title: string): Promise<T> {
+async function savePage(url: string, title: string) {
   return fetch('https://us-central1-poolbase-123.cloudfunctions.net/savePage', {
     method: 'POST',
     mode: 'cors',
@@ -12,20 +12,20 @@ async function savePage<T>(url: string, title: string): Promise<T> {
       title,
     }),
   }).then(
-    (response): Promise<T> => {
+    (response) => {
       if (!response.ok) {
         throw new Error(response.statusText);
       }
-      return response.json() as Promise<T>;
+      return response.json();
     }
   );
 }
 
 chrome.browserAction.onClicked.addListener(function(tab): void {
   // Send a message to the active tab
-  chrome.tabs.query({ active: true, currentWindow: true }, async function(tabs): void {
+  chrome.tabs.query({ active: true, currentWindow: true }, async function(tabs) {
     const activeTab = tabs[0];
-    const response = await savePage<{}>(activeTab.url, activeTab.title);
+    const response = await savePage(activeTab.url, activeTab.title);
     console.log(response);
     chrome.tabs.sendMessage(activeTab.id, {
       message: 'clicked_browser_action',

diff --git a/packages/browser-extension/tsconfig.json b/packages/browser-extension/tsconfig.json
@@ -2,6 +2,7 @@
   "compilerOptions": {
     "module": "commonjs",
     "target": "es6",
+    "lib": ["es2018", "dom"],
     "noImplicitAny": false,
     "sourceMap": false,
     "rootDir": "src",