Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 51 #52

Merged
merged 8 commits into from
May 7, 2021
Merged

Issue 51 #52

merged 8 commits into from
May 7, 2021

Conversation

LilyAndres
Copy link
Collaborator

Address #51 changed the templates using LibreOffice, I didn't use google docs because I had some issues before.
I also changed the design pattern yaml file by removing 'plant structure' for 'material entity'.
I also ran the steps in the wiki "Intermediate CDNO Compile Instructions", so two owl files have been updated as well.
I created templates/include/BFO_includes.txt file

Could you please have a look @kaiiam? I hope these changes are ok, we can discuss about it, thanks.

@LilyAndres LilyAndres requested a review from kaiiam May 5, 2021 14:29
@kaiiam
Copy link
Collaborator

kaiiam commented May 7, 2021

Working with @LilyAndres we've updated the command in https://github.com/Southern-Cross-Plant-Science/cdno/wiki/Intermediate-CDNO-Compile-Instructions to replace PO plant structure with BFO material entity. This is now working in this PR having updated everything. However we now have the issue that some classes are asserted as subclass to material entity when we only want them to show up in cdno-edit.owl as subclass to the appropriate terms from the dietary nutritional component hierarchy.

image

We've decided to merge this for now, but we'll need to make a new issue/PR to deal with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants