"Repo is too big to import"

[dgennetten]

Consistently getting "Repo is too big to import" for all links launched from v2.grommet.io.

Example: https://codesandbox.io/s/github/grommet/grommet-site?initialpath=button&module=%2Fscreens%2FButton.js

[CompuIves]

Thanks for letting me know! The line throwing the error is here: https://github.com/codesandbox-app/git-extractor/blob/master/src/routes/github/api.ts#L479. The zip of the repo is 112MB, which was above the 30MB limit we set, we set this limit to make sure we don't hit any memory limit. I raised the limit to 128MB now, but there seems to be another limit that's hit. I can check tomorrow what limit that is and maybe raise it, I think it may be the file count limit (is set to 100 right now).

The public/img/image*.js files in the grommet-site repo are the files that cause it to hit the limit now, so if they are not important you can also delete those files and it'll work.

Regardless, we should re-evaluate our limits from time to time. I can check tomorrow if we can raise any other limits 😄 .

[ryanpcmcquen]

Did the limits ever get raised here @CompuIves? Curious for this and: #1007

[CompuIves]

Yes! It's now double if I'm not mistaken (200 files). Not that we don't count node_modules in this calculation.

[ryanpcmcquen]

@CompuIves, any plan to raise it more? I must have hit the 200 module limit for my repo ...

[rowild]

This error message appears after uploading one simple, small vue file already...

[CompuIves]

Do you have an example @rowild? The error shouldn't happen for less than 200 files. We're planning to raise the limit this week.

[rowild]

With example, do you mean a project at codesandbox that I should share?
https://codesandbox.io/s/lp2o446nrz
Please have a look into the folder "components" and try to open "jvds-main.vue".
It happens with any file.

[CompuIves]

Oh wow, that's a different issue but totally shouldn't happen @rowild. I committed a fix for it and should be up today (1b241e6).

[rowild]

Wow! Thanks for reacting so quickly! But just to let you know: this also happens wit SCSS files. I added one.

(BTW: uploaded once on Firefox, once on Chrome [where I have some extensions like AdGuard]: same result. But realize another thing: codeSandbox does not update - which is ok -, but an update button the tree view would be awesome!)

[CompuIves]

Oh man, I thought our zip implementation would've seen those as text files. A quick fix would be to add them to the list of forced text extensions (the ones defined here https://github.com/CompuIves/codesandbox-client/blob/master/packages/app/src/app/store/modules/files/actions.js#L70-L73). Would you be interested in adding it @rowild? Otherwise I can do it too.

[rowild]

Ha! You are challenging me! :-)
Ok, I gave it a try! If this is BS, please let me know how to improve!
Thank you!

BTW: Uploading to a folder is only possible, if the folder is opened. Uploads won't work if the folder is closed. This is somewhat irritating, since every folder has its own handle icons anyway. So: is this by design and intentional? If so, a warning message would be nice. And if not, please let me know, then I file a separat bug report.

[rowild]

Thanks! What about my questions though? The closed folder, the update button... Any info for me? ;-)

[CompuIves]

What about my questions though? The closed folder, the update button... Any info for me? ;-)

Do you mean with this that we should auto open a folder if you hover long enough on it?

[rowild]

No, I think autoOpen on hover would yield a very stressful user experience. But the fact that you can only upload a file, when the folder is open, and not, when it is closed, should in some way be communicated to the user, IMO. Otherwise I assume: "Ah, each folder has its own upload button, cool! So I do not need to open the e.g. scss folder, instead I just click on the upload button, upload the file and it should be there."
Fact is, that the upload actually reacts to this user behavior and makes me believe the file was uploaded. But only after a manual check - by opening the scss folder - I see that it, in fact, was NOT uploaded.

There could be 3 solution:

1. Make it possible to upload to a closed folder.
2. Provide some sort of feedback, like: "Uploading to closed folder is forbidden".
3. Hide the upload button, as long as the folder is closed.

Currently I would dare to say that "just making it possible" would be the easiest solution, implementation-wise and user-experience-wise... but I have really waaaaay too little experience with such a huge project like yours!

(And also an update button, the refreshed the list of files, would be great!)

[github-actions]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

[github-actions]

This issue has been automatically closed because there wasn't any activity after the previous notice or the stale label wasn't removed.