We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@psychocoderHPC just realized the following:
it would be quite neat if we could replace the hard-coded boost min-version in FindmallocMC.cmake by the following logic inside FindmallocMC.cmake:
FindmallocMC.cmake
mallocMC_BOOST_MIN_VERSION
find_package(Boost mallocMC_BOOST_MIN_VERSION REQUIRED)
This PR is to remind that we need, e.g., close to version.h or CMakeList.txt a define that can be queried.
version.h
CMakeList.txt
The text was updated successfully, but these errors were encountered:
maybe this can also be solved with cmake config files (?) @slizzered @erikzenker
Sorry, something went wrong.
can be moved to 2.3+
the boost depedency is removed with #169 so I will close this issue
nice, for the record, the right way to do this these days would have been with the find_dependency(...) macro: https://github.com/openPMD/openPMD-api/blob/0.11.1-alpha/openPMDConfig.cmake.in#L26 https://cmake.org/cmake/help/v3.17/module/CMakeFindDependencyMacro.html
find_dependency(...)
No branches or pull requests
@psychocoderHPC just realized the following:
it would be quite neat if we could replace the hard-coded boost min-version in FindmallocMC.cmake by the following logic inside
FindmallocMC.cmake
:mallocMC_BOOST_MIN_VERSION
)find_package(Boost mallocMC_BOOST_MIN_VERSION REQUIRED)
This PR is to remind that we need, e.g., close to
version.h
orCMakeList.txt
a define that can be queried.The text was updated successfully, but these errors were encountered: