Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost dependency: grep-able #114

Closed
ax3l opened this issue Nov 13, 2015 · 4 comments
Closed

boost dependency: grep-able #114

ax3l opened this issue Nov 13, 2015 · 4 comments
Milestone

Comments

@ax3l
Copy link
Member

ax3l commented Nov 13, 2015

@psychocoderHPC just realized the following:

it would be quite neat if we could replace the hard-coded boost min-version in FindmallocMC.cmake by the following logic inside FindmallocMC.cmake:

  • find mallocMC
  • parse min version (to CMake var mallocMC_BOOST_MIN_VERSION)
  • find_package(Boost mallocMC_BOOST_MIN_VERSION REQUIRED)

This PR is to remind that we need, e.g., close to version.h or CMakeList.txt a define that can be queried.

@ax3l
Copy link
Member Author

ax3l commented Nov 13, 2015

maybe this can also be solved with cmake config files (?)
@slizzered @erikzenker

@ax3l
Copy link
Member Author

ax3l commented Dec 2, 2015

can be moved to 2.3+

@ax3l ax3l modified the milestones: 2.3.0crp, 2.2.1crp: Bug Fixes Dec 2, 2015
@ax3l ax3l modified the milestones: 2.4.0crp, 2.5.0crp Feb 13, 2019
@psychocoderHPC
Copy link
Member

the boost depedency is removed with #169 so I will close this issue

@ax3l
Copy link
Member Author

ax3l commented Jul 13, 2020

nice, for the record, the right way to do this these days would have been with the find_dependency(...) macro:
https://github.com/openPMD/openPMD-api/blob/0.11.1-alpha/openPMDConfig.cmake.in#L26
https://cmake.org/cmake/help/v3.17/module/CMakeFindDependencyMacro.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants