Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bingeboard #68

Merged

Conversation

liam-middlebrook
Copy link
Member

Adds the bingeboard table to the database.
This table stores stats about the player that are updated on each turn.

A working example of this being utilized is at https://binge.csh.rit.edu
This example provided by:
https://github.com/liam-middlebrook/bingehack4-binge-api
https://github.com/liam-middlebrook/bingehack4-bingeboard-web

Once this is merged I'll transfer ownership of the two repos listed above to ComputerScienceHouse's GitHub organization so it's "official"

I already have this running on bingehack prod, but I figure it's better to get review before officially merging it in.

Fixes #43

@liam-middlebrook
Copy link
Member Author

Let me know if you feel like I should be tracking any other stats in turn-time.

attrib_int_str, attrib_wis_str, attrib_dex_str, attrib_con_str,
attrib_cha_str, score_str
};
const int paramFormats[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const int paramFormats[] = { 0 }; is a better way to initialize this to 0.

http://stackoverflow.com/a/201116

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, fixed.

attrib_int_str, attrib_wis_str, attrib_dex_str, attrib_con_str,
attrib_cha_str, score_str
};
const int paramFormats[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use = { 0 } here too

Adds the bingeboard table to the database.
This table stores stats about the player that are updated on each turn.

A working example of this being utilized is at https://binge.csh.rit.edu
This example provided by:
https://github.com/liam-middlebrook/bingehack4-binge-api
https://github.com/liam-middlebrook/bingehack4-bingeboard-web
Copy link
Member

@cgonyeo cgonyeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me

@liam-middlebrook liam-middlebrook merged commit ebec702 into ComputerScienceHouse:master Mar 20, 2017
@liam-middlebrook liam-middlebrook deleted the bingeboard branch March 20, 2017 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants