-
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(problem_matcher): ignore ANSI color escape codes for matching
When PackSquash outputs log messages with colors, problem matchers do not seem to work. However, they worked fine in the past, when colors were not printed. I suspected that GitHub not removing ANSI color escape codes before matching could be the culpirit, and indeed there are some ignored GitHub issues in the VS Code repositories about it (GitHub runners inherit problem matchers from VS Code). Let's tweak the regexes used for matching to take into account the ANSI escape sequences that PackSquash may use. To test that they work as expected, temporarily introduce a failure in a test workflow.
- Loading branch information
1 parent
c84fd43
commit 11fa3f7
Showing
2 changed files
with
18 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters