Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with mem_prv_observ argument #76

Open
bradduthie opened this issue Aug 3, 2021 · 2 comments
Open

Problem with mem_prv_observ argument #76

bradduthie opened this issue Aug 3, 2021 · 2 comments
Assignees

Comments

@bradduthie
Copy link
Member

The mem_prv_observ argument takes a boolean value, but it is unclear to me why we would ever need this value to be TRUE. Should it not always be TRUE when using the trajectory method of prediction?

Additionally, there is an error in the code on this line, which reads:

if(mem == FALSE){

FALSE is equivalent to 0 in R, but not C, so I will change this to 0. and push a new version.

bradduthie added a commit that referenced this issue Aug 3, 2021
…' to '0' in manager function for C. @AdrianBach -- would be could to double check that this if-else is necessary?
@bradduthie
Copy link
Member Author

I've now swapped the line so that it reads as follows:

if(mem == 0){

This should be okay then, but it's still not quite clear that the if/else is needed?

@AdrianBach
Copy link
Collaborator

Hi @bradduthie !

Hope all is well !

Yes, this if else is needed because mem == 0 corresponds to the ATI strategy and mem > 0 to TRJ strategy. Is this the if else you are talking about?

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants