Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Sahi proxy method which remove the authorization header (e.g. Bearer Token) #306

Closed
toschneck opened this issue Feb 2, 2018 · 0 comments

Comments

@toschneck
Copy link
Contributor

toschneck commented Feb 2, 2018

For some web application which use a construct like "Bearer Tokens" Sahi removes the authorization header and so break the tests: The website will continuously logout and are not controllable.

Example:

    _navigateTo("https://onlinerechner.contactm.de/b-os/");
    _highlight(_div("Produkt & Varianten auswählen"));

Like also discussed at Sahi Community - Authorization header getting stripped out this behavior is not wanted.

Solution:
Skip the execution of the action HttpRequest.removeHeader("Authorization")

Tasks:

  • Add a advice to Sakuli to skip the execution if removeHeader will be called with the value "Authorization"
  • Add the property sahi.proxy.removeAuthorizationHeader.enabled: is set to true like the default behavior of sahi (We don't know the impact on other applications)
  • Add a documentation page like "Know Sahi Issues"
@toschneck toschneck added this to the rel-v1.2 milestone Feb 2, 2018
@toschneck toschneck self-assigned this Feb 2, 2018
toschneck pushed a commit that referenced this issue Feb 2, 2018
@toschneck toschneck changed the title Suppress Sahi Proxy to remove Authorization Header (Bearer Token) Disable Sahi proxy method which remove the authorization header (e.g. Bearer Token) Feb 2, 2018
toschneck pushed a commit that referenced this issue Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant