Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling changes and proper tooltips #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Concept211
Copy link
Owner

@Concept211 Concept211 commented Nov 29, 2016

Not sure if you're interested, but I made several CSS changes and also updated all alt tags to title tags so that they will properly show up as tooltips. I believe IE was the only browser that used alt tags as tooltips and no one should be using it in coming years (thank goodness).
snap138

@misterunknown
Copy link

misterunknown commented Nov 30, 2016

I like your design very much, great work! The alt properties were relicts from years ago, where HTML4.1 required these. So I wasn't aware of them anyway^^

Unfortunately you applied your changes directly to the ifm.php file. As of version 2 this file is just generated by the compiler.php which in turn compiles the sources from the src directory. If you want, you can apply your changes directly to the source files and recreate the pull request. Otherwise I will implement them myself – but I think you are faster ;)

"Compiling", by the way, is deadly simple: Just run "php compiler.php". This creates a new ifm.php from the sources.

I also plan to write a little contribution guide soon ;)

@Concept211
Copy link
Owner Author

Sounds good - I'll download the full source and update the corresponding files when I get a chance.

Thanks!

@Concept211
Copy link
Owner Author

Ok, I created a new pull request:
misterunknown#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants