Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alphanumeric cleanup #18

Merged
merged 3 commits into from
Feb 14, 2023
Merged

alphanumeric cleanup #18

merged 3 commits into from
Feb 14, 2023

Conversation

ConchuOD
Copy link
Owner

@ConchuOD ConchuOD commented Feb 9, 2023

Qinglin pointed out an issue with my alphanumeric selects check & I figured that really it should be a warning as I think the script sometimes does odd things with depend/default that adds noise when someone is adding a new config option.

Qinglin pointed out that the output from this test really isn't helpful
at all as it doesn't say *what* it dislikes.
This happens because the diff goes to stdout, but nipa only collects
stderr. Redirect the output there instead.

That said, the output isn't very useful.
Apply some formatting to the output so that it suggests the fixup that
it wants to see.

Reported-by: Qinglin Pan <panqinglin2020@iscas.ac.cn>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
…d about

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
@ConchuOD
Copy link
Owner Author

Following an irc chat about this, settled upon some other changes. The output from Qinglin's patchset would now be:

New out of order content added
Ideally, sort depends first, the default second, selects (in alphanumerical order) third.
Suggested fixups:
config RISCV_ISA_SVNAPOT					config RISCV_ISA_SVNAPOT
	bool "SVNAPOT extension support"				bool "SVNAPOT extension support"
	depends on 64BIT && MMU						depends on 64BIT && MMU
	default y					     <
	select RISCV_ALTERNATIVE					select RISCV_ALTERNATIVE
							     >		default y
	help								help
	 Allow kernel to detect the SVNAPOT ISA-extension dy		 Allow kernel to detect the SVNAPOT ISA-extension dy
	 time and enable its usage.					 time and enable its usage.

	 The SVNAPOT extension is used to mark contiguous PT		 The SVNAPOT extension is used to mark contiguous PT
	 of contiguous virtual-to-physical translations for 		 of contiguous virtual-to-physical translations for 
	 aligned power-of-2 (NAPOT) granularity larger than 		 aligned power-of-2 (NAPOT) granularity larger than 
	 size. When HUGETLBFS is also selected this option u		 size. When HUGETLBFS is also selected this option u
	 allocates some memory for each NAPOT page size supp		 allocates some memory for each NAPOT page size supp
	 When optimizing for low memory consumption and for 		 When optimizing for low memory consumption and for 
	 the SVNAPOT extension, it may be better to say N he		 the SVNAPOT extension, it may be better to say N he

	 If you don't know what to do here, say Y.			 If you don't know what to do here, say Y.

Copy link
Collaborator

@bjoto bjoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! LGTM!

@ConchuOD ConchuOD merged commit 2c09bd9 into main Feb 14, 2023
@ConchuOD ConchuOD deleted the alphanumeric-cleanup branch April 4, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants