Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concise.css/src/_atgrid.scss [container] #262

Closed
ghost opened this issue Jan 16, 2017 · 3 comments
Closed

concise.css/src/_atgrid.scss [container] #262

ghost opened this issue Jan 16, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 16, 2017

No description provided.

@ghost
Copy link
Author

ghost commented Jan 16, 2017

James,

The previous "issue" I opened and you accepted on this topic has a problem. Sorry.

If at the end of a container there is something similar to a dropdown menu with hidden items that extend beyond the container, a double scroll bar is displayed. See attached screenshot. The screenshots show Firefox, Chrome and Safari under OS-X.

I stumbled across a very simple and Concise solution.

  1. Remove the "overflow: auto" we added to _atgrid.scss
  2. In concise.css/src/_base.scss
    :root {
    -- background-color: getColor(background, body);

++ body {
++ background-color: getColor(background, body);
++ }

I am uncertain why this fix works, it makes no sense to me, but it does.

I believe this change is safe for the current version of Concise CSS.

container-overflow-auto
root-background-color
no-root-background-color

@ghost
Copy link

ghost commented Jan 17, 2017

Hi @fredhall

I also noticed that changing the background color from :root to body solved the problem, but because your solution also worked for me, I used that one, I didn't know it also created another scrollbar.

So I’ll add this change, but I’m not quite sure if it’s safe for a patch version because some users might be doing unexpected things so we can’t assume. What I’m going to do, is to remove the overflow: auto and change the background rule in a next major version.

But don’t worry, that won’t take too long, I have some plans for that as I mentioned in the last email :)

@ghost ghost self-assigned this Jan 17, 2017
@ghost ghost added the ver:Future label Jan 17, 2017
ghost pushed a commit that referenced this issue Feb 4, 2017
- Remove "overflow: auto" from _atgrid.scss
- Move the background declaration to body instead of :root
@ghost ghost closed this as completed Feb 4, 2017
@ghost
Copy link

ghost commented Feb 4, 2017

Alright, I have added the change in the development branch. Thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants