Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity with old wallet crypto library #42

Open
bisgardo opened this issue Apr 27, 2024 · 0 comments
Open

Feature parity with old wallet crypto library #42

bisgardo opened this issue Apr 27, 2024 · 0 comments
Assignees
Labels
[Type] Task An additional feature or improvement.

Comments

@bisgardo
Copy link
Contributor

The SDK is not yet on feature parity with the old mobile_wallet library. The library is integrated into the reference iOS wallet as a Swift package located in the repository that has been repuposed into ConcordiumWalletCrypto (which is a part of this SDK).

Most notably, the SDK only supports a single kind of account transactions, namely transfer. The old one supported all kinds of transactions. Also, deserialization of smart contract parameters is needed for the approval screen for WalletConnect requests.

It seems reasonable to assume that all the functions in the old library are currently in use by the wallets. This means that the SDK will have to reach full feature parity before migrating the wallets to this SDK is feasible.

@bisgardo bisgardo added the [Type] Task An additional feature or improvement. label Apr 27, 2024
@mh-concordium mh-concordium added the [Res] works as designed The functionality is as intended. label May 13, 2024 — with Linear
@mh-concordium mh-concordium removed the [Res] works as designed The functionality is as intended. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants