Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create internal interface for XML parsing #18

Closed
taveras opened this issue Dec 14, 2017 · 1 comment
Closed

Create internal interface for XML parsing #18

taveras opened this issue Dec 14, 2017 · 1 comment
Assignees
@pgoldrbx
Labels
enhancement in progress

Comments

@taveras
Copy link
Contributor

taveras commented Dec 14, 2017

We should extract XML parsing into our own internal helper, which would act as an interface between xmldom and xml-to-react.
This would make it easier to test our other helpers, and to better test XML parsing error conditions.

related:
#16 (comment)
#14
@taveras taveras mentioned this issue Dec 14, 2017
Merged
@pgoldrbx pgoldrbx self-assigned this Dec 15, 2017
@pgoldrbx
Copy link
Contributor

I have begun this work

@pgoldrbx pgoldrbx mentioned this issue Dec 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgoldrbx pgoldrbx

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taveras @pgoldrbx