Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Open Source Checklist #23

Open
22 of 28 tasks
gautamarora opened this issue Dec 20, 2017 · 9 comments
Open
22 of 28 tasks

Complete Open Source Checklist #23

gautamarora opened this issue Dec 20, 2017 · 9 comments

Comments

@gautamarora
Copy link
Contributor

gautamarora commented Dec 20, 2017

This is a master issue to work through the Condé Nast Open Source Checklist.

Documentation

Development

  • Tests
  • Linter
  • Travis
  • Examples
  • Clear Github History

README Checklist

Badges Checklist:

  • License Badge
  • Testing Badge
  • CI Badge
@pgoldrbx
Copy link
Contributor

@taveras
Copy link
Contributor

taveras commented Jan 5, 2018

@gautamarora do we have a particular asset to use for the Condé Nast Technology logo?

@gautamarora
Copy link
Contributor Author

yes, i will add it to templates and report back.

@gautamarora
Copy link
Contributor Author

@taveras logos for cn tech have been added here

@gautamarora
Copy link
Contributor Author

image

This was referenced Jan 18, 2018
@taveras
Copy link
Contributor

taveras commented Jan 18, 2018

@gautamarora @johnkpaul @pgoldrbx how do we feel about the Clear Github History item in the checklist?

we can remove / flatten a few those merge commits if we'd like, but is there any other feedback for what should be changed?

@gautamarora
Copy link
Contributor Author

@taveras - I think that is more relevant from the POV of not having commits that show sensitive data (before open sourcing) in the repo, but this project has been clean from the get go, so not an issue for it.

@johnkpaul
Copy link

The reason why that was asked for by the lawyers was because it helped mitigate any worry around accidentally revealing anything we didn't want to reveal when considering moving something from internal and private to public and open source.

In this particular case, it was written as standalone from the beginning and I don't have concerns the git history could cause problems.

@taveras
Copy link
Contributor

taveras commented Jan 18, 2018

👌 this makes sense, and understood! checking off that item on the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants