Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Logger does not work in Open #5

Closed
lovromazgon opened this issue Mar 31, 2022 · 0 comments · Fixed by #6
Closed

Bug: Logger does not work in Open #5

lovromazgon opened this issue Mar 31, 2022 · 0 comments · Fixed by #6
Assignees
Labels
bug Something isn't working

Comments

@lovromazgon
Copy link
Member

In PR #4 the context passed to Open was replaced with a new context so that we can control how long it stays open. The problem is that this approach doesn't forward the context values that might be present in the original context, like for example the logger.

We should probably explore another approach like detaching the parent cancellation from the context instead of creating a fresh context (see this thread for more info).

@lovromazgon lovromazgon added the bug Something isn't working label Mar 31, 2022
@lovromazgon lovromazgon self-assigned this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant